✨ Enable CI-Tests to run as commit-based check
#1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeemshaikh38
requested review from
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
+ Coverage 57.02% 60.24% +3.22%
==========================================
Files 63 63
Lines 6192 6186 -6
==========================================
+ Hits 3531 3727 +196
+ Misses 2420 2212 -208
- Partials 241 247 +6 |
naveensrinivasan
approved these changes
Mar 16, 2022
Test already exists in |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enable
CI-Testas a commit-based check. This is the final check needed to support a commit-specific Scorecard result.(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
No support for commit-specific Scorecard result.
What is the new behavior (if this is a feature change)?**
Adds support for
--commit=option in Scorecard CLI.Yes,
e2e/ci_tests_test.gohas tests for this.Which issue(s) this PR fixes
Fixes #575
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)