Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add raw results to cron scans #1741

Merged
merged 12 commits into from
Mar 19, 2022
Merged

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Mar 17, 2022

Adds the raw results to cron jobs
no breaking changes

Note: I have not created the buckets and tables yet. I'll do more testing but would like to get reviews in the meantime.

Add raw results to the weekly cron

@laurentsimon laurentsimon temporarily deployed to integration-test March 17, 2022 02:14 Inactive
@laurentsimon laurentsimon marked this pull request as draft March 17, 2022 02:14
@laurentsimon laurentsimon changed the title ✨ Add raw results to cron scans ✨ (DRAFT) Add raw results to cron scans Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1741 (a4292d9) into main (d5893c2) will increase coverage by 3.17%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   56.62%   59.79%   +3.17%     
==========================================
  Files          65       65              
  Lines        6388     6377      -11     
==========================================
+ Hits         3617     3813     +196     
+ Misses       2530     2317     -213     
- Partials      241      247       +6     

@github-actions
Copy link

@laurentsimon laurentsimon marked this pull request as ready for review March 17, 2022 03:54
@laurentsimon laurentsimon changed the title ✨ (DRAFT) Add raw results to cron scans ✨ Add raw results to cron scans Mar 17, 2022
@laurentsimon laurentsimon temporarily deployed to integration-test March 17, 2022 04:07 Inactive
@github-actions
Copy link

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left some comments, will take another look later.

cron/k8s/controller.release.yaml Outdated Show resolved Hide resolved
cron/config/config.go Outdated Show resolved Hide resolved
cron/format/json_raw_results.go Show resolved Hide resolved
cron/k8s/raw-transfer-v0.yaml Outdated Show resolved Hide resolved
cron/k8s/transfer.raw-release-v0.yaml Outdated Show resolved Hide resolved
@laurentsimon laurentsimon temporarily deployed to integration-test March 18, 2022 19:43 Inactive
@laurentsimon
Copy link
Contributor Author

I can merge this today, so long as it won't impact the weekly scan. Can you confirm the weekly scan only uses hash commit that successfully passed the releasetest?

@github-actions
Copy link

@laurentsimon laurentsimon temporarily deployed to integration-test March 18, 2022 19:51 Inactive
@github-actions
Copy link

@laurentsimon laurentsimon temporarily deployed to integration-test March 18, 2022 19:59 Inactive
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@azeemshaikh38
Copy link
Contributor

I can merge this today, so long as it won't impact the weekly scan. Can you confirm the weekly scan only uses hash commit that successfully passed the releasetest?

Feel free to merge this in. You'll need to to kubectl apply -f locally (we don't have this automated yet). It will get tested in releasetest first before running in the prod cron job.

@laurentsimon laurentsimon merged commit b1ab16e into ossf:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants