Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug in Scorecard tag Docker image creation #1890

Merged
merged 2 commits into from
May 6, 2022

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

There is a bug in how we generate Docker images for new tags (like v4.2.0). Currently we tag HEAD as the latest tag irrespective of which commit the tag it applied to. This PR fixes that.

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Bug fix in Docker image creation

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 6, 2022 19:33 Inactive
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1890 (b666da2) into main (8c97d46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   51.27%   51.27%           
=======================================
  Files          80       80           
  Lines        6797     6797           
=======================================
  Hits         3485     3485           
  Misses       3081     3081           
  Partials      231      231           

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) May 6, 2022 19:48
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test May 6, 2022 19:54 Inactive
@github-actions
Copy link

github-actions bot commented May 6, 2022

@github-actions
Copy link

github-actions bot commented May 6, 2022

@azeemshaikh38 azeemshaikh38 merged commit 5758364 into main May 6, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/cloudbuild branch May 6, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants