Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Feature: Dependency-diff ecosystem naming convention mapping (GitHub -> OSV) #2088

Merged
merged 12 commits into from
Jul 25, 2022
Merged

✨ Feature: Dependency-diff ecosystem naming convention mapping (GitHub -> OSV) #2088

merged 12 commits into from
Jul 25, 2022

Conversation

aidenwang9867
Copy link
Contributor

@aidenwang9867 aidenwang9867 commented Jul 22, 2022 •
edited
Loading

What kind of change does this PR introduce?

  1. Dependency ecosystem naming convention: map ecosystem names using the GitHub naming convention into names using the OSV naming convention.

What is the current behavior?

GetDependencydiffResults returns depdency-diff check results with package ecosystem names in the GitHub naming convention.

What is the new behavior (if this is a feature change)?**

GH -> OSV.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2078

Special notes for your reviewer

Please LGTM and merge this PR first, then #2077. This one optimizes the Dependency-diff API and has higher priority.

Does this PR introduce a user-facing change?

No.

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@codecov
Copy link

codecov bot commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #2088 (193a2f5) into main (8f96d6b) will increase coverage by 0.06%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #2088      +/-   ##
==========================================
+ Coverage   42.13%   42.19%   +0.06%     
==========================================
  Files          92       93       +1     
  Lines        7569     7595      +26     
==========================================
+ Hits         3189     3205      +16     
- Misses       4132     4141       +9     
- Partials      248      249       +1

laurentsimon
laurentsimon reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
The PR does a lot more than the title suggest. Try do do one thing as per tiel in each PR to simplify review.

dependencydiff/mapping.go Outdated Show resolved Hide resolved
dependencydiff/mapping.go Outdated Show resolved Hide resolved
@aidenwang9867
Copy link
Contributor Author

Thanks. The PR does a lot more than the title suggest. Try do do one thing as per tiel in each PR to simplify review.

I'll separate it into two PRs: (1) the mapping and (2) the optimizations (var name, logic) in my next push, thanks!

laurentsimon
laurentsimon approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 22, 2022 20:59 Inactive
@github-actions
Copy link

Integration tests success for
[4b9e138]
(https://github.com/ossf/scorecard/actions/runs/2721146699)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 23, 2022 04:13 Inactive
@github-actions
Copy link

Integration tests success for
[04b46ea]
(https://github.com/ossf/scorecard/actions/runs/2722374891)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 23, 2022 05:06 Inactive
@github-actions
Copy link

Integration tests success for
[a975ce6]
(https://github.com/ossf/scorecard/actions/runs/2722532792)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 23, 2022 06:54 Inactive
@github-actions
Copy link

Integration tests success for
[8c52f06]
(https://github.com/ossf/scorecard/actions/runs/2722811631)

@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 25, 2022 02:29 Inactive
@github-actions
Copy link

Integration tests success for
[b0baedc]
(https://github.com/ossf/scorecard/actions/runs/2729506495)

@laurentsimon laurentsimon enabled auto-merge (squash) July 25, 2022 15:58
@aidenwang9867 aidenwang9867 temporarily deployed to integration-test July 25, 2022 17:28 Inactive
@github-actions
Copy link

Integration tests success for
[193a2f5]
(https://github.com/ossf/scorecard/actions/runs/2734101615)

@laurentsimon laurentsimon merged commit 66708ba into ossf:main Jul 25, 2022
singhsaurabh pushed a commit to singhsaurabh/scorecard that referenced this pull request Jul 25, 2022
@aidenwang9867
✨ Feature: Dependency-diff ecosystem naming convention mapping (GitHu…
b00d0a4 
…b -> OSV) (ossf#2088)

* save

* save

* save

* save

* save

* save
@aidenwang9867 aidenwang9867 deleted the depdiff_mapping branch July 28, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@azeemshaikh38 azeemshaikh38 Awaiting requested review from azeemshaikh38

@justaugustus justaugustus Awaiting requested review from justaugustus

@naveensrinivasan naveensrinivasan Awaiting requested review from naveensrinivasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: map the current Dependencydiff package naming convention (GitHub) to OSV
2 participants
@aidenwang9867 @laurentsimon