🌱 Split CI-Tests check into a raw and evaluation section #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restructure data by grouping commits by Pull Request Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 41.28% 40.51% -0.77%
==========================================
Files 110 112 +2
Lines 8773 8818 +45
==========================================
- Hits 3622 3573 -49
- Misses 4885 4984 +99
+ Partials 266 261 -5 |
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
force-pushed
the
split-citests-check-raweval
branch
from
a6703a6
to
2a384a9
Compare
|
Integration tests success for |
|
Integration tests success for |
laurentsimon
approved these changes
Sep 22, 2022
|
Integration tests success for |
|
Integration tests success for |
raghavkaul
added a commit
to raghavkaul/scorecard
that referenced
this pull request
Oct 21, 2022
* Split CI tests into a raw and evaluation section * Restructure data by grouping commits by Pull Request Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Fix linter & license Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Split CI tests into a raw and evaluation section * Restructure data by grouping commits by Pull Request Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Fix linter & license Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Split CI tests into a raw and evaluation section * Restructure data by grouping commits by Pull Request Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Fix linter & license Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul
added a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
* Split CI tests into a raw and evaluation section * Restructure data by grouping commits by Pull Request Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Fix linter & license Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Splits CI-Test checks into a Raw and Evaluation section. This will make it easier to implement scorecard-attestor.
What is the new behavior (if this is a feature change)?**
This change also fixes a bug where we previously overcounted CheckRuns and Statuses in repos with un-squashed PRs.
Special notes for your reviewer
Scores for GitHub repos that don't squash PRs will be more accurately counted for the CI-Tests check. This change removes behavior where we double counted CI Tests run on a single commit across all commits in a PR.