🐛 Ensure CODEOWNERS file exists for corresponding Branch-Protection check #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
raghavkaul
changed the title
|
Integration tests success for |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2463 +/- ##
==========================================
- Coverage 39.95% 39.92% -0.04%
==========================================
Files 122 122
Lines 9815 9852 +37
==========================================
+ Hits 3922 3933 +11
- Misses 5612 5637 +25
- Partials 281 282 +1 |
|
Integration tests success for |
laurentsimon
approved these changes
Dec 7, 2022
* If CODEOWNERS file doesn't exist, CODEOWNERS branch protection is not in effect even if the setting is enabled Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
force-pushed
the
bugfix-codeowners-ensurefile
branch
from
0146987
to
8719a2b
Compare
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
laurentsimon
approved these changes
Dec 14, 2022
raghavkaul
added a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
…heck (ossf#2463) * Ensure CODEOWNERS file exists for corresponding Branch-Protection check * If CODEOWNERS file doesn't exist, CODEOWNERS branch protection is not in effect even if the setting is enabled Signed-off-by: Raghav Kaul <raghavkaul@google.com> * cr comments Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Ensure that the CODEOWNRS file exists for the corresponding Branch-Protection check by gathering a set of CODEOWNERS files in the repo. If file doesn't exist, CODEOWNERS branch protection is not in effect even if the setting is enabled. This fixes a bug where we would have incorrectly reported scores for the branch protection check.
Which issue(s) this PR fixes
Fixes #2348.