Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor githubrepo CheckRun logic #2710

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

azeemshaikh38
Copy link
Contributor

What kind of change does this PR introduce?

Refactoring to keep all check run code in one place. No logic change.

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 2, 2023 12:47 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 2, 2023 12:48 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #2710 (b07f6b9) into main (82a122b) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2710      +/-   ##
==========================================
+ Coverage   41.29%   41.31%   +0.02%     
==========================================
  Files         123      123              
  Lines       10046    10039       -7     
==========================================
  Hits         4148     4148              
+ Misses       5602     5595       -7     
  Partials      296      296              

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 2, 2023 13:45 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) March 2, 2023 13:52
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test March 2, 2023 19:11 — with GitHub Actions Inactive
@azeemshaikh38 azeemshaikh38 merged commit 846fb19 into ossf:main Mar 2, 2023
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants