🌱 Add projects to cronjob #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnacht
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
=========================================
+ Coverage 0 41.33% +41.33%
=========================================
Files 0 123 +123
Lines 0 10041 +10041
=========================================
+ Hits 0 4150 +4150
- Misses 0 5595 +5595
- Partials 0 296 +296 |
spencerschrock
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Thanks.
Given that the Scorecard API doesn't perform redirects from old repo names to new ones, we need to update projects occasionally.
This will probably need some discussion that is beyond the scope of this PR. In my opinion, what you have now works. There may be some duplicate work done, but both names will work on the scorecard side of things. Since each result is generated separately, there is a possibility for some inconsistent results between old/new name.
Adds: - bufbuild/protoc-gen-validate - rust-lang/cfg-if - codemirror/codemirror5 - firebase/flutterfire - google/zerocopy - openjdk/jdk19u - tukaani-project/xz Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
naveensrinivasan
force-pushed
the
new_urls
branch
from
1681982
to
79b29d1
Compare
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
Adds: - bufbuild/protoc-gen-validate - rust-lang/cfg-if - codemirror/codemirror5 - firebase/flutterfire - google/zerocopy - openjdk/jdk19u - tukaani-project/xz Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
Adds: - bufbuild/protoc-gen-validate - rust-lang/cfg-if - codemirror/codemirror5 - firebase/flutterfire - google/zerocopy - openjdk/jdk19u - tukaani-project/xz Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds 7 popular projects to cronjob:
Note that two of these repositories already exist in projects.csv, but with old names:
Given that the Scorecard API doesn't perform redirects from old repo names to new ones, we need to update projects occasionally. I wasn't sure whether it's best to replace them or add them as duplicates (in case someone relies on the old name). Let me know if I should replace them instead.