🌱 Setup cron for running as GitHub App #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
…und for the auth server not supporting it. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
…ome checks. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
…ens. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus,
laurentsimon,
naveensrinivasan and
raghavkaul
as code owners
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
=======================================
Coverage 41.39% 41.39%
=======================================
Files 124 124
Lines 10164 10164
=======================================
Hits 4207 4207
Misses 5659 5659
Partials 298 298 |
laurentsimon
approved these changes
Mar 6, 2023
azeemshaikh38
approved these changes
Mar 6, 2023
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
* Update auth server to use GitHub App. Signed-off-by: Spencer Schrock <sschrock@google.com> * Update release worker to use GitHub App tokens directly, as a workaround for the auth server not supporting it. Signed-off-by: Spencer Schrock <sschrock@google.com> * Add Retry-After logic and stats. Signed-off-by: Spencer Schrock <sschrock@google.com> * Change retry-after logic to support any status code. Disable troublesome checks. Signed-off-by: Spencer Schrock <sschrock@google.com> * Use GitHub App Token instead of auth server. Signed-off-by: Spencer Schrock <sschrock@google.com> * Temporarily disable additional chhecks. Signed-off-by: Spencer Schrock <sschrock@google.com> * Disable github auth server as it doesn't work with the GitHub App Tokens. Signed-off-by: Spencer Schrock <sschrock@google.com> * Re-enable Fuzzing check in the release test. Signed-off-by: Spencer Schrock <sschrock@google.com> * Fix unit test for new check change. Signed-off-by: Spencer Schrock <sschrock@google.com> * Move opencensus stat to the ratelimit roundtripped. Signed-off-by: Spencer Schrock <sschrock@google.com> --------- Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
* Update auth server to use GitHub App. Signed-off-by: Spencer Schrock <sschrock@google.com> * Update release worker to use GitHub App tokens directly, as a workaround for the auth server not supporting it. Signed-off-by: Spencer Schrock <sschrock@google.com> * Add Retry-After logic and stats. Signed-off-by: Spencer Schrock <sschrock@google.com> * Change retry-after logic to support any status code. Disable troublesome checks. Signed-off-by: Spencer Schrock <sschrock@google.com> * Use GitHub App Token instead of auth server. Signed-off-by: Spencer Schrock <sschrock@google.com> * Temporarily disable additional chhecks. Signed-off-by: Spencer Schrock <sschrock@google.com> * Disable github auth server as it doesn't work with the GitHub App Tokens. Signed-off-by: Spencer Schrock <sschrock@google.com> * Re-enable Fuzzing check in the release test. Signed-off-by: Spencer Schrock <sschrock@google.com> * Fix unit test for new check change. Signed-off-by: Spencer Schrock <sschrock@google.com> * Move opencensus stat to the ratelimit roundtripped. Signed-off-by: Spencer Schrock <sschrock@google.com> --------- Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
cron update
What is the current behavior?
The cron used personal access tokens
What is the new behavior (if this is a feature change)?**
retry-afterheaders and some metrics when/if we see it.Dependency-Update-ToolFuzzing, which should be re-enabled again soon now that 🐛 Check OSS Fuzz build file for Fuzzing check #2719 is mergedSASTVulnerabilitiesdue to an inefficiency in osv-scanner that has been fixed upstream but needs a new release cutBranch-Protectioncheck while using a GitHub App token[] Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)