🐛 Ignore unpinned dependencies in Dockerfiles in vendored directories #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
justaugustus and
laurentsimon
and removed request for
a team
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
==========================================
- Coverage 76.12% 70.52% -5.60%
==========================================
Files 205 205
Lines 14050 14068 +18
==========================================
- Hits 10696 9922 -774
- Misses 2723 3570 +847
+ Partials 631 576 -55 |
raghavkaul
approved these changes
Nov 16, 2023
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
ignore-vendored-unpinned-dependencies
branch
from
4962379
to
0310029
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This checks whether Dockerfiles being checked by Pinned Dependencies are in a
vendororthird_partydirectory.(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
With this PR, Scorecard will check whether any of the subdirectories that a file exists in is called either
vendororthird_party.Which issue(s) this PR fixes
#1095
Special notes for your reviewer
Does this PR introduce a user-facing change?
Yes, scores will change, but that is inherited from #1095