✨ enforce check scores are between the min and max #3769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature / bug fix combined?
What is the current behavior?
there was no logic on what the scores could be
What is the new behavior (if this is a feature change)?**
if the score is invalid, the Error field is set and the score is replaced with an inconclusive result score.
Which issue(s) this PR fixes
Related to #3766
Special notes for your reviewer
I have this split into two commits, because I'm not certain about forcing callers who want
InconclusiveResultScore
to useCreateInconclusiveResult
, but I think it's the right decision. The goal is partly to enforce a consistent coding style, and partly to limit proportions which score to -1 accidentally.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)