Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ignore .git folder for localdir #3943

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

naveensrinivasan
Copy link
Member

@naveensrinivasan naveensrinivasan commented Mar 12, 2024

  • ignore .git folder for localdir

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3908

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


- ignore .git folder for localdir

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #3943 (3c03bdf) into main (bfc8f37) will decrease coverage by 4.60%.
The diff coverage is 40.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3943      +/-   ##
==========================================
- Coverage   74.95%   70.36%   -4.60%     
==========================================
  Files         222      222              
  Lines       15807    15811       +4     
==========================================
- Hits        11848    11125     -723     
- Misses       3196     3971     +775     
+ Partials      763      715      -48     

@naveensrinivasan naveensrinivasan merged commit 1bd4af7 into main Mar 13, 2024
41 of 42 checks passed
@naveensrinivasan naveensrinivasan deleted the naveen/fix/localdir branch March 13, 2024 12:45
fhoeborn pushed a commit to fhoeborn/scorecard that referenced this pull request Apr 1, 2024
- ignore .git folder for localdir

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature: Skip .git folder in localdir client
2 participants