-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add lifecycle field to probes #4147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
Some are listed as stable if they're not expected to change, others are listed as experimental if there are still expected changes. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
June 5, 2024 23:35 — with
GitHub Actions
Inactive
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
force-pushed
the
lifecycle
branch
from
June 11, 2024 21:36
afcefb0
to
38e38f3
Compare
spencerschrock
temporarily deployed
to
integration-test
June 11, 2024 21:37 — with
GitHub Actions
Inactive
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
force-pushed
the
lifecycle
branch
from
June 21, 2024 17:15
38e38f3
to
f8ce10a
Compare
spencerschrock
had a problem deploying
to
integration-test
June 21, 2024 17:16 — with
GitHub Actions
Error
This PR marks all probes as stable, except for the following:
|
spencerschrock
requested review from
naveensrinivasan
and removed request for
a team
June 21, 2024 17:19
This pull request has been marked stale because it has been open for 10 days with no activity |
raghavkaul
approved these changes
Jul 2, 2024
spencerschrock
temporarily deployed
to
integration-test
July 2, 2024 17:04 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
structured results update
What is the current behavior?
There is no indication around whether a probe can be depended on or not. And there are examples of probes being removed (#3666 and #3559 (comment))
What is the new behavior (if this is a feature change)?**
Clearly mark if a probe is:
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)