🌱 add stack info to osv-scanner error #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zxilly
requested review from
naveensrinivasan and
spencerschrock
and removed request for
a team
Zxilly
had a problem deploying
to
integration-test
GitHub Actions
Failure
Zxilly
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
One e2e test failed, reaching Github speed limit, not related with this patch. |
Signed-off-by: Zxilly <zxilly@outlook.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
spencerschrock
approved these changes
Jun 14, 2024
|
Thank you! |
|
I'm wondering when will we got a new release. |
For our CLI and action, we are targeting end of the month for the full, non-release candidate v5. This code is already deployed in our infrastructure though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
only print a error string for osv-scanner panic error
What is the new behavior (if this is a feature change)?**
also print the stacktrace
Which issue(s) this PR fixes
Updates #4171
Special notes for your reviewer
Does this PR introduce a user-facing change?