Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 git ignore vendor folder #4335

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

6543
Copy link
Contributor

@6543 6543 commented Sep 4, 2024

minor .gitignore change

@6543 6543 requested a review from a team as a code owner September 4, 2024 21:25
@6543 6543 requested review from justaugustus and raghavkaul and removed request for a team September 4, 2024 21:25
@6543 6543 changed the title git ignore vendor folder 👻 git ignore vendor folder Sep 4, 2024
@6543 6543 changed the title 👻 git ignore vendor folder 👻 git ignore vendor folder Sep 4, 2024
Signed-off-by: 6543 <6543@obermui.de>
@6543
Copy link
Contributor Author

6543 commented Sep 5, 2024

-> added better description

@spencerschrock
Copy link
Contributor

Can you explain the motivation for this change? We don't vendor dependencies in this project, are you trying to locally?

@6543
Copy link
Contributor Author

6543 commented Sep 10, 2024

Some tooling does work better if you go mod vendor a golang prohect first ...

... but as you mention you dont vendor this files in git, so it should be ignored to not interfear

@6543
Copy link
Contributor Author

6543 commented Sep 11, 2024

@spencerschrock ☝️ ?

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Signed-off-by: 6543 <6543@obermui.de>
@spencerschrock spencerschrock merged commit 9ff40de into ossf:main Sep 12, 2024
36 checks passed
@6543 6543 deleted the ignore-vendor-folder branch September 15, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants