🌱 Fix goreleaser permissions #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests success for 1d31de436c7912707bc9eeb26058249962e2afc3 |
* Fix the goreleaser permissions to read contents and write deployments
naveensrinivasan
force-pushed
the
naveen/feat/fix/go-releaser-permissions
branch
from
1d31de4 to
2477d11
Compare
|
Integration tests success for 2477d1172ccdac85095db3e1d4a6723198289e4d |
|
Not yet ready, figuring out the right permissions. |
laurentsimon
approved these changes
Sep 9, 2021
| @@ -19,6 +19,18 @@ on: | |||
| tags: | |||
| - "*" # triggers only if push new tag version, like `0.8.4` or else | |||
|
|
|||
| permissions: | |||
| actions: none | |||
There was a problem hiding this comment.
same comment as other PR. You can remove the name: none
|
ETA on this PR? |
|
this is interesting https://github.com/apps/step-security |
The hard thing with this is to only make releases to determine the right permissions. |
|
Integration tests success for 95db6ac782b31bc94606a187120ff4b987170f53 |
|
It will be addressed by #1164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Scorecard repo fails at
Token-Permissionswith score0#942What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
No