-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitvote.yml passing threshold to 55% (5/9) #455
Conversation
Signed-off-by: Riaan Kleinhans <61125752+riaankleinhans@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit on the percentage.
I can't say how the initial threshold was defined nor any discussion on changing it, did I miss it? |
The TAC decision process is documented here and describes various different types of decisions. This may complicate the configuration of gitvote as in fact multiple different thresholds are needed per type of request. I am currently not knowledgable enough to judge if gitvote can to this, but it is important to document that this configuration only applies to certain types of votes. For TI funding requests, the currently defined threshold is 5 approvals out of 9 TAC members, making it effectively a 55.55% (let's say 56%) threshold. |
It seems like the TAC decision process and TI funding request process docs are a bit out of sync actually. The former indicates a 7d review for TI funding requests, where all of our current review cycles in the latter indicate a 14d review period. Not a major issue, but it would be good to sync those. And for the number of votes needed to approve funding requests (and even TI lifecycle applications, for example), I tend to agree with @lehors that a simple majority doesn't seem enough. That is, getting more eyes and reviews on these sorts of decisions upfront can helps with communication within the TAC and keeping everyone informed. |
@justaugustus @steiza @lehors @marcelamelara @gkunz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm a bit behind in reviewing this! And also sorry that the initial funding process in 2025 hasn't been clear.
My intention with #435 is that the funding cycle review process go for 2 weeks, and that we continue to use the 5 out of 9 approvers we had in 2024 per https://github.com/ossf/tac/blob/main/process/TAC-Decision-Process.md (although as @marcelamelara notes, we should update that doc to reflect the 2 week waiting period).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, fine with me. And I have to admit that I got the ratio backwards during my first review. So, yes, 55 (or 51) works for me. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @riaankleinhans ! I'm approving these changes to bring our process in sync with what we have documented, but I do think that we ought to separately revisit our approval thresholds.
Signed-off-by: Riaan Kleinhans <61125752+riaankleinhans@users.noreply.github.com>
No description provided.