CWE-754 - Improper Check for Unusual or Exceptional Conditions - Float #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartlomiej Karas <bartlomiej.karas@ericsson.com>
myteron
reviewed
Apr 3, 2025
myteron
reviewed
Apr 3, 2025
Contributor
myteron
left a comment
myteron
left a comment
There was a problem hiding this comment.
sorry about this. bunch of issus need to be address that I did not see while it was in confluence for some reason.
myteron
requested changes
Apr 3, 2025
Contributor
myteron
left a comment
myteron
left a comment
There was a problem hiding this comment.
need a bunch of changes that I did not see while it was in confluence for some reason.
Co-authored-by: myteron <myteron@gmail.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Co-authored-by: myteron <myteron@gmail.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
I removed Bibliography section, it was actually not leading to an external link Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Updated Helge's "remove fluff" comment, including type fix Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Co-authored-by: myteron <myteron@gmail.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Added: # TODO: input sanitation. # TODO: proper exception handling Into the "add_to_package" function Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Left a sentence about the output of "compliant01.py" Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Contributor
|
Reviewing this as well. |
s19110
reviewed
Apr 17, 2025
Contributor
s19110
left a comment
s19110
left a comment
There was a problem hiding this comment.
Mostly cosmetic suggestions. The rule itself looks good.
docs/Secure-Coding-Guide-for-Python/CWE-703/CWE-754/noncompliant01.py
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-703/CWE-754/noncompliant01.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Helge Wehder <helge.wehder@ericsson.com>
myteron
approved these changes
Apr 17, 2025
Contributor
myteron
left a comment
myteron
left a comment
There was a problem hiding this comment.
Hi @BartKaras1128 hi @s19110 . I applied a ton of cosmetics like backticks, fixed links in readme and a table. Could not help get rid of the warnings in my ide.
@BartKaras1128, I approve but believe Hubert has found some flaws he comment on that need fixing
Happy with that, changing it now. Co-authored-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Co-authored-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
…nt01.py Co-authored-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
…nt01.py Co-authored-by: Hubert Daniszewski <61824500+s19110@users.noreply.github.com> Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
I added Hubert's suggested change to the "noncompliant01.py" section Signed-off-by: Bartlomiej Karas <moezarts@gmail.com>
Signed-off-by: myteron <myteron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CWE-754 README.md along with 2 new code examples.