-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/9/transaction form #18
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/m-ossolinski/coderscamp-2021-spa-project-2/4h86hZ5jwLVgwsyk8ZT2tgfkcAb3 |
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
My overall conclusion is that:
|
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
src/pages/TransactionsPage/TransactionsForm/TransactionsForm.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my review, enjoy :)
created Date Picker component,
created Number Input component,
created Text Input component,
created Radio Input component,
created Time Picker component,
created FormButton component,
created Transactions Form component in pages.
I have some problems while coding the dropdown component, I found out that it is impossible to style HTML option tags and it to have a nice custom dropdown component it will be needed to code it from scratch. I can do it but it will take me some time to accomplish it. Let me know if we can have not-that-custom component for it or I should code it from scratch.
The second issue is with managing the state of the form, just want to check if I am coding it right. Actually, it applies to all my code, I am not sure if I am coding components right and will need some guidance if it is alright so far. I decided to put submit and cancel buttons already in the
Transaction form
component but I am not sure if it is what we want.I left a red border for now so it is easier to see how the content looks, it will be deleted before the final code.