Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/9/transaction form #18

Merged
merged 34 commits into from
Jan 31, 2022
Merged

Feature/9/transaction form #18

merged 34 commits into from
Jan 31, 2022

Conversation

axseinga
Copy link
Collaborator

  • created Date Picker component,

  • created Number Input component,

  • created Text Input component,

  • created Radio Input component,

  • created Time Picker component,

  • created FormButton component,

  • created Transactions Form component in pages.

I have some problems while coding the dropdown component, I found out that it is impossible to style HTML option tags and it to have a nice custom dropdown component it will be needed to code it from scratch. I can do it but it will take me some time to accomplish it. Let me know if we can have not-that-custom component for it or I should code it from scratch.

The second issue is with managing the state of the form, just want to check if I am coding it right. Actually, it applies to all my code, I am not sure if I am coding components right and will need some guidance if it is alright so far. I decided to put submit and cancel buttons already in the Transaction form component but I am not sure if it is what we want.

I left a red border for now so it is easier to see how the content looks, it will be deleted before the final code.

@vercel
Copy link

vercel bot commented Jan 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/m-ossolinski/coderscamp-2021-spa-project-2/4h86hZ5jwLVgwsyk8ZT2tgfkcAb3
✅ Preview: https://coderscamp-2021-spa-project-2-git-feature-9-5cd78b-m-ossolinski.vercel.app

src/components/form/DropdownInput/DropdownInput.js Outdated Show resolved Hide resolved
src/components/form/FormButton/FormButton.js Outdated Show resolved Hide resolved
src/components/form/TextInput/TextInput.js Outdated Show resolved Hide resolved
src/components/form/TextInput/TextInput.js Outdated Show resolved Hide resolved
src/components/form/TimePicker/TimePicker.js Outdated Show resolved Hide resolved
@ossmate
Copy link
Owner

ossmate commented Jan 20, 2022

My overall conclusion is that:

  • custom inputs have to be more generic - which means that we should pass our own implementation of onchage and pass the values as props
  • for input components we also should be able to pass it type
  • we shouldt pass handle form callback to input
  • button should be more generic - it will not be used only form Forms

Copy link
Collaborator

@radekwojpl2 radekwojpl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my review, enjoy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants