Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: SrsStatistic::on_stream_close does not release streams, causing memory leaks. #2136

Closed
JalySN opened this issue Jan 9, 2021 · 3 comments
Closed

API: SrsStatistic::on_stream_close does not release streams, causing memory leaks. #2136

JalySN opened this issue Jan 9, 2021 · 3 comments
Assignees
@duiniuluantanqin
Labels
good first issue Easy to fix issues, good for newcomers PullRequest Has PR or solution in issue. TransByAI Translated by AI/GPT.
Milestone
5.0

Comments

@JalySN
Copy link

JalySN commented Jan 9, 2021 •
edited by winlinvip
Loading

Check for memory leaks, and find that this function has already erased the pointer from the streams map. Does this mean that the streams are leaking at this point?

TRANS_BY_GPT3
@JalySN
Copy link
Author

JalySN commented Jan 9, 2021 •
edited by winlinvip
Loading

In addition, there is another place SrsHlsMuxer::update_config
whether srs_freep(writer) is needed.

TRANS_BY_GPT3

@duiniuluantanqin
Copy link
Member

duiniuluantanqin commented Jan 28, 2021 •
edited by winlinvip
Loading

need

TRANS_BY_GPT3

@winlinvip winlinvip changed the title SrsStatistic::on_stream_close需要析构stream吗？ PR：SrsStatistic::on_stream_close需要析构stream吗？ Feb 28, 2021
@winlinvip winlinvip added the PullRequest Has PR or solution in issue. label Feb 28, 2021
@winlinvip winlinvip changed the title PR：SrsStatistic::on_stream_close需要析构stream吗？ API：SrsStatistic::on_stream_close需要析构stream吗？ Aug 22, 2021
@winlinvip winlinvip changed the title API：SrsStatistic::on_stream_close需要析构stream吗？ API：SrsStatistic::on_stream_close没有释放streams导致内存泄漏 Aug 22, 2021
@winlinvip winlinvip added this to the SRS 4.0 release milestone Aug 26, 2021
@winlinvip winlinvip added the good first issue Easy to fix issues, good for newcomers label Jan 17, 2022
@winlinvip winlinvip modified the milestones: 4.0, 5.0 Aug 19, 2022
winlinvip added a commit that referenced this issue Aug 19, 2022
@winlinvip
For #2136: API: Cleanup no active streams for statistics. v5.0.42
54a457e
winlinvip added a commit that referenced this issue Aug 19, 2022
@winlinvip
For #2136: HLS: Delete the writer when update config.
db8872a
@winlinvip
Copy link
Member

winlinvip commented Aug 19, 2022 •
edited
Loading

@JalySN Thank you, it has already been fixed in 5.0. 👍

Welcome to join our development group, let's contribute code together. You can contact me on WeChat. 😄

TRANS_BY_GPT3

winlinvip added a commit that referenced this issue Aug 19, 2022
@winlinvip
For #2136: API: Cleanup no active streams for statistics. v5.0.42
e9d6601
winlinvip added a commit that referenced this issue Aug 24, 2022
@winlinvip
For #2136: API: Cleanup no active streams for statistics. v4.0.256
8e6d207
@winlinvip winlinvip changed the title API：SrsStatistic::on_stream_close没有释放streams导致内存泄漏 API: SrsStatistic::on_stream_close does not release streams, causing memory leaks. Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duiniuluantanqin duiniuluantanqin

Labels
good first issue Easy to fix issues, good for newcomers PullRequest Has PR or solution in issue. TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
3 participants
@winlinvip @duiniuluantanqin @JalySN