Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Support statistic and on_play/stop for HLS stream #2578

Merged
merged 4 commits into from
Sep 23, 2021

Conversation

duiniuluantanqin
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #2578 (a00554a) into develop (7ab3e4a) will increase coverage by 1.47%.
The diff coverage is 58.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2578      +/-   ##
===========================================
+ Coverage    59.14%   60.61%   +1.47%     
===========================================
  Files          122      122              
  Lines        51759    55103    +3344     
===========================================
+ Hits         30613    33403    +2790     
- Misses       21146    21700     +554     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_http_api.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/protocol/srs_http_stack.hpp | 100.00% <ø> (ø) | |'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_http_api.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/protocol/srs_http_stack.hpp | 100.00% <ø> (ø) | |
| trunk/src/app/srs_app_http_static.cpp | 45.41% <51.08%> (+4.54%) | ⬆️ |
| trunk/src/protocol/srs_http_stack.cpp | 92.83% <66.66%> (-0.26%) | ⬇️ |
| trunk/src/utest/srs_utest_http.cpp | 99.73% <100.00%> (+<0.01%) | ⬆️ |
| trunk/src/app/srs_app_threads.cpp | 60.10% <0.00%> (-2.50%) | ⬇️ |
| trunk/src/app/srs_app_dvr.cpp | 0.00% <0.00%> (ø) | |'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_dvr.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/utest/srs_utest_kernel.cpp | 98.83% <0.00%> (+0.33%) | ⬆️ |
| trunk/src/app/srs_app_hybrid.cpp | 12.96% <0.00%> (+1.85%) | ⬆️ |
| ... and 5 more | |


Continue to review full report at Codecov.

Legend - Click here to learn more
| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Translated to English while maintaining the markdown structure:

| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update 7ab3e4a...a00554a. Read the comment docs.

TRANS_BY_GPT3

#include <srs_app_http_hooks.hpp>
#include <srs_app_statistic.hpp>

#define SRS_SECRET_IN_HLS "srs_secret"
Copy link
Collaborator

@xiaozhihong xiaozhihong Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secret' feels like it would be better to change the name. My first reaction is always "key"... If you don't look closely, you might think this is some kind of authentication code. Maybe changing it to 'userid', 'uniqueid', or 'magicid' would be better?

TRANS_BY_GPT3

@winlinvip winlinvip merged commit f901831 into ossrs:develop Sep 23, 2021
winlinvip pushed a commit that referenced this pull request Sep 23, 2021
…2578)

* Enhance HLS: support http callback on_play/stop, support statistic

* make code readable

* make code readable

* rename secret
winlinvip added a commit that referenced this pull request Sep 23, 2021
@winlinvip winlinvip changed the title Enhance HLS: support http callback on_play/stop, support statistic API: Support statistic and on_play/stop for HLS stream Jan 14, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
4 participants