-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Support statistic and on_play/stop for HLS stream #2578
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2578 +/- ##
===========================================
+ Coverage 59.14% 60.61% +1.47%
===========================================
Files 122 122
Lines 51759 55103 +3344
===========================================
+ Hits 30613 33403 +2790
- Misses 21146 21700 +554 | Impacted Files | Coverage Δ | |' Translated to English while maintaining the markdown structure: '| Impacted Files | Coverage Δ | | Translated to English while maintaining the markdown structure: '| trunk/src/app/srs_app_http_api.cpp | Translated to English while maintaining the markdown structure: '| trunk/src/app/srs_app_dvr.cpp | Continue to review full report at Codecov.
Translated to English while maintaining the markdown structure: |
|
#include <srs_app_http_hooks.hpp> | ||
#include <srs_app_statistic.hpp> | ||
|
||
#define SRS_SECRET_IN_HLS "srs_secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
secret' feels like it would be better to change the name. My first reaction is always "key"... If you don't look closely, you might think this is some kind of authentication code. Maybe changing it to 'userid', 'uniqueid', or 'magicid' would be better?
TRANS_BY_GPT3
663863e
to
edce854
Compare
…2578) * Enhance HLS: support http callback on_play/stop, support statistic * make code readable * make code readable * rename secret
No description provided.