-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22 #3389
Kernel: Fix demux SPS error for NVENC and LARIX. v6.0.22 #3389
Conversation
it's not working yet. When I stream using NVENC, I get this:
and when I tried to play the .ts stream, I get this
|
Do you successfully publish stream through LARIX APP? But you failed to play the .ts stream, url looks like |
Yes, I was able to see the stream details on the webUI of SRS it was not showing blank anymore, but when I tried to play the srt_hevc_nvenc.ts didn't work. |
@johan149 Have you played other stream url, for instance,
|
If enable HLS and HTTP-TS, SRS can't identify the protocol(HLS or HTTP-TS) when viewer accesses the url So, we should detect the conflict for HLS and HTTP-TS, which should return error when enable both. Let me file another issue for this #3391 |
Oh yes, I had HLS, and TS turned ON. Let me try now with just SRT, FLV, HLS |
@chundonglinlin @winlinvip, here are the results of the test I conducted. Publish
WORKS---------------FFmpeg libx265 Publish
WORKS--------------FFmpeg libx265 Play
WORKS--------------FLV |
Do you test my branch( Moreover, Do you have OBS-hevc plugin for test? You can provide me for test. |
Yes, I'm using your branch, and I get this error while trying to stream with Larix and when I tried to stream with OBS-HEVC I get this error I gave you access to a server with nvenc and obs support so we can test. check discord. |
sub_layer_profile_space.clear(); | ||
sub_layer_tier_flag.clear(); | ||
sub_layer_profile_idc.clear(); | ||
sub_layer_profile_compatibility_flag.clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When released, these vectors don't need to be taken care of, right? They will be released automatically.
TRANS_BY_GPT3
sub_layer_level_idc.clear(); | ||
} | ||
|
||
srs_error_t SrsHevcProfileTierLevel::dumps(SrsHevcProfileTierLevel* ptl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do a direct value copy?
*this = *ptl
Or maybe we don't need to use dumps, just do a direct assignment.
sps->ptl.dumps(&profile_tier_level);
Change it to...
sps->ptl = profile_tier_level;
TRANS_BY_GPT3
When publish stream with NVENC and LARIX by SRT or RTMP, maybe demux pps failed. Likely,