WebRTC: Warning if no ideal profile. v6.0.33, v5.0.146 #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipeng19811218
approved these changes
Mar 4, 2023
chundonglinlin
approved these changes
Mar 4, 2023
chen-guanghua
approved these changes
Mar 4, 2023
winlinvip
changed the title
winlinvip
added a commit
that referenced
this pull request
Mar 7, 2023
For WebRTC, SRS expect the h.264 codec is: ``` a=rtpmap:106 H264/90000 a=fmtp:106 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f ``` But sometimes, the device does not support the profile, for example only bellow: ``` a=fmtp:123 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e033 a=fmtp:122 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=420033 a=fmtp:121 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=640033 a=fmtp:120 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=4d0033 ``` So we should warning user about the profile missmatch, because it might not work. PICK a751448 ---------- Co-authored-by: chundonglinlin <chundonglinlin@163.com> Co-authored-by: LiPeng <lipeng19811218@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WebRTC, SRS expect the h.264 codec is:
But sometimes, the device does not support the profile, for example only bellow:
So we should warning user about the profile missmatch, because it might not work.