-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Support HTTP basic authentication for API. v6.0.4, v5.0.152 #3458
API: Support HTTP basic authentication for API. v6.0.4, v5.0.152 #3458
Conversation
After enabling authentication, will the Console prompt this popup? Check if there is a popup in the Console, as many people have reported that there is no authentication in the Console. Therefore, it would be good to have a popup, not having one might not be ideal. Does this also apply to the RTC API? The RTC API belongs to the streaming media part, so if RTC is enabled, should HTTP-FLV also be enabled for consistency? The API is for operations and maintenance, while streaming media is for users, so the passwords for these two may be different. The HTTP server and API can reuse the same port, so we may need to check if it will function properly.
|
Please add black box testing and use Go as the client to verify if the auth is correct.
|
321f71b
to
d70cee6
Compare
d70cee6
to
f27e44f
Compare
c056094
to
2ac9eb8
Compare
I think it works for me now, please also remember to update the documentation for HTTP basic authentication at HTTP-API |
PICK 771ae0a Co-authored-by: winlin <winlin@vip.126.com> Co-authored-by: john <hondaxiao@tencent.com>
The 'Basic' HTTP Authentication Scheme
Refer to RFC7617, currently only authentication for HTTP API has been implemented.
Configuration
Testing
Alternatively, accessing it directly through the browser will prompt for entering a username and password.
Modification Plan
The original process is as follows:
The new process adds
SrsHttpAuthMux
as follows:Note:
API is for operations and maintenance, while streaming media is for users, these two passwords may be different.
, authentication is only performed for/api/v1/
, while other endpoints such as RTC signaling/rtc/v1/
are not authenticated.API
.TRANS_BY_GPT3