Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHIP: Add OBS support, ensuring compatibility with a unique SDP. v5.0.158, v6.0.51 #3581

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

winlinvip
Copy link
Member

@winlinvip winlinvip commented Jun 12, 2023

  1. Ignore SDP GROUP LS.
  2. Support ice in global session info.
  3. Support audio codec "OPUS" or "opus".

See obsproject/obs-studio#7926

Known issue:

See also #3170

1. Ignore SDP GROUP LS.
2. Support ice in global session info.
3. Support audio codec "OPUS" or "opus".
@winlinvip winlinvip requested a review from johzzy June 12, 2023 07:08
@winlinvip winlinvip linked an issue Jun 12, 2023 that may be closed by this pull request
@winlinvip winlinvip changed the title WHIP: Support OBS WHIP. WHIP: Support OBS WHIP SDP format. Jun 12, 2023
@winlinvip winlinvip changed the title WHIP: Support OBS WHIP SDP format. WHIP: Add OBS WHIP support, ensuring compatibility with a unique SDP format. Jun 12, 2023
@winlinvip winlinvip changed the title WHIP: Add OBS WHIP support, ensuring compatibility with a unique SDP format. WHIP: Add OBS support, ensuring compatibility with a unique SDP format. Jun 12, 2023
@winlinvip winlinvip changed the title WHIP: Add OBS support, ensuring compatibility with a unique SDP format. WHIP: Add OBS support, ensuring compatibility with a unique SDP Jun 12, 2023
@winlinvip winlinvip merged commit 7f997b3 into ossrs:develop Jun 15, 2023
winlinvip added a commit that referenced this pull request Jun 15, 2023
….158, v6.0.51 (#3581)

1. Ignore SDP GROUP LS.
2. Support ice in global session info.
3. Support audio codec "OPUS" or "opus".

---------

Co-authored-by: Johnny <hellojinqiang@gmail.com>
@winlinvip winlinvip changed the title WHIP: Add OBS support, ensuring compatibility with a unique SDP WHIP: Add OBS support, ensuring compatibility with a unique SDP. v5.0.158, v6.0.51 Jun 15, 2023
@linkewei0580
Copy link

linkewei0580 commented Jun 15, 2023

I often tried it out, OBS Whip can stream to SRS/6.0.51(Bee).

TRANS_BY_GPT3

@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
winlinvip added a commit that referenced this pull request Sep 21, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/

RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/

Please note that SRS 5.0 already had WHIP support. I didn't write a
document about WHIP, because WHIP is not a RFC right now, but there are
clues in
[srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS
WHIP url for publisher:
`http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream`

This PR is for WHEP, the url for player is
`http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream`

PS: There is a great PR for OBS to have WHIP support, see
obsproject/obs-studio#7926 and #3581

PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1

See #3170


---------

Co-authored-by: Haibo Chen <495810242@qq.com>
Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: ChenGH <chengh_math@126.com>
winlinvip added a commit that referenced this pull request Sep 21, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/

RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/

Please note that SRS 5.0 already had WHIP support. I didn't write a
document about WHIP, because WHIP is not a RFC right now, but there are
clues in
[srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS
WHIP url for publisher:
`http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream`

This PR is for WHEP, the url for player is
`http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream`

PS: There is a great PR for OBS to have WHIP support, see
obsproject/obs-studio#7926 and #3581

PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1

See #3170

---------

Co-authored-by: Haibo Chen <495810242@qq.com>
Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: ChenGH <chengh_math@126.com>
duiniuluantanqin added a commit to duiniuluantanqin/srs that referenced this pull request Oct 11, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/

RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/

Please note that SRS 5.0 already had WHIP support. I didn't write a
document about WHIP, because WHIP is not a RFC right now, but there are
clues in
[srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS
WHIP url for publisher:
`http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream`

This PR is for WHEP, the url for player is
`http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream`

PS: There is a great PR for OBS to have WHIP support, see
obsproject/obs-studio#7926 and ossrs#3581

PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1

See ossrs#3170

---------

Co-authored-by: Haibo Chen <495810242@qq.com>
Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: ChenGH <chengh_math@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebRTC: Failed to handshake with OBS WHIP
3 participants