This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Use rustix instead of nix #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends #200 which is a clean prep patch that can be merged now. |
|
OK lifting draft on this one. This also relates to coreos/rpm-ostree#3311 in that we want to drop nix/openat from the ostree dependency chain ideally first. |
|
(We should use cap-std here too, but that's a larger churn) |
|
Changes lgtm, I wonder why CI is failing on both PRs with the same issue, do we need to force these in? |
|
I clearly should have tested #203 locally - we need that first because we're pulling containers-image-proxy from git now, so CI started failing after containers/containers-image-proxy-rs#24 was merged. (I did actually test that PR but with a different branch) |
|
I guess we need a rebase now. |
This is safer and may actually fix a race condition I've seen sometimes in CI runs. Part of investigating using rustix (and cap-std) in our section of the ecosystem (xref rust-lang/rfcs#2610).
By using rustix for uname.
|
Rebased 🏄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this actually, the owned/borrowed FD stuff is definitely nicer. I still need to investigate whether the rustix ecosystem has something like this fd passing-to-
Commandthat we need.