This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Add a helper to flatten Result<Result<T>> with tokio_util
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
approved these changes
Jan 19, 2022
lib/src/tokio_util.rs
Outdated
Comment on lines
60
to
61
| Ok(Ok(v)) => Ok(v), | ||
| Ok(Err(e)) => Err(e), |
There was a problem hiding this comment.
Couldn't this be written:
Suggested change
| Ok(Ok(v)) => Ok(v), | |
| Ok(Err(e)) => Err(e), | |
| Ok(x) => x, |
?
There was a problem hiding this comment.
Ah nice! I started to reply "No because..." then I realized if you just look at it, it's clearly true.
There was a problem hiding this comment.
In my defense this code was inspired by rust-lang/rust#70142 (comment) but they're trying to support a "flatten with" which we're hardcoding to be anyhow! effectively. This code is also not as general because it requires the inner to be an anyhow::Result today.
I think this is nicer than having `??` which still looks odd to me, and we can also drop a `map(anyhow::Error::msg)` in once place too. Prep for further work.
cgwalters
force-pushed
the
spawn-blocking-flatten
branch
from
3feb966
to
92c3303
Compare
jlebon
approved these changes
Jan 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is nicer than having
??which still looks odd to me,and we can also drop a
map(anyhow::Error::msg)in once place too.Prep for further work.