-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ostree-prepare-root: print st_dev and st_ino as 64-bit ints #2219
ostree-prepare-root: print st_dev and st_ino as 64-bit ints #2219
Conversation
Wait no, I don't think this is right actually. |
This matches what systemd does and should work fine on all platforms. Possibly resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1888436
caef3d1
to
dec9eab
Compare
OK digging into the type of /hold cancel |
Ah right we're passing a 64 bit value in args but systemd is only shifting 32. It's unfortunate this isn't caught by the compiler...probably gcc isn't smart enough to understand the systemd journaling API? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
for manual testing
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
This matches what systemd does and should work fine on all platforms.
Possibly resolves: bugzilla.redhat.com/show_bug.cgi?id=1888436