ci: Run GH action CI build+test as non-root #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
test-nonroot-ci
branch
2 times, most recently
from
294036f to
ea2ec16
Compare
|
Hmm. Well, that worked. |
|
LGTM, although I think this skips some other tests which only run as root. |
|
Whee right, we have |
cgwalters
force-pushed
the
test-nonroot-ci
branch
from
ea2ec16 to
7c19612
Compare
This is really the standard best practice, matching how e.g. dpkg/rpm work, as well as most local development environments (including mine) with e.g. `toolbox`.
cgwalters
force-pushed
the
test-nonroot-ci
branch
from
7c19612 to
fdeee16
Compare
But it turns out right now the Jenkins flow is doing CI as uid 0, so we should be running this there. |
dbnicholson
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really the standard best practice, matching how
e.g. dpkg/rpm work, as well as most local development
environments (including mine) with e.g.
toolbox.