-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy: Add bootloader-naming-2 opt-in #3007
Merged
jmarrero
merged 1 commit into
ostreedev:main
from
cgwalters:optin-new-bootloader-naming
Aug 24, 2023
Merged
deploy: Add bootloader-naming-2 opt-in #3007
jmarrero
merged 1 commit into
ostreedev:main
from
cgwalters:optin-new-bootloader-naming
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've verified that this fixes compatibility with GRUB, which parses the filename: ostreedev#2961 However, out of a large degree of conservatism I've made this an opt-in behavior for now. My plan is to test it out in the FCOS development streams first.
Skipping CI for Draft Pull Request. |
Merged
cgwalters
changed the title
deploy: Add bootloader-naming-2 opt-init
deploy: Add bootloader-naming-2 opt-in
Aug 24, 2023
jmarrero
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Nov 8, 2023
- This removes the autoprune stuff which is already always on in ostree now - Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Nov 8, 2023
- This removes the autoprune stuff which is already always on in ostree now - Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
Looks good:
|
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Nov 9, 2023
- This removes the autoprune stuff which is already always on in ostree now - Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
dustymabe
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Nov 9, 2023
- This removes the autoprune stuff which is already always on in ostree now - Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
aaradhak
pushed a commit
to aaradhak/fedora-coreos-config
that referenced
this pull request
Mar 18, 2024
- This removes the autoprune stuff which is already always on in ostree now - Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've verified that this fixes compatibility with GRUB, which parses the filename:
#2961
However, out of a large degree of conservatism I've made this an opt-in behavior for now.
My plan is to test it out in the FCOS development streams first.