repo/commit: Support group-writable files for bare-user-only #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't have coverage of this before, and adding the test infrastructure will help ensure we have coverage for more changes here.
|
Canonical is 755/644 you mean? |
These exist in the wild for flatpak, and aren't really a problem. The canonical permissions are still either `0755` or `0644`, we just support the additional writable bit for the group (i.e. extend the set to include `0775` and `0664`) now to avoid breaking some flatpak content.
cgwalters
force-pushed
the
bareuseronly-canonical-2
branch
from
4dac395 to
d313ae6
Compare
|
Yeah, pushed with a reworded commit message. |
|
@rh-atomic-bot r+ d313ae |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 7, 2017
We didn't have coverage of this before, and adding the test infrastructure will help ensure we have coverage for more changes here. Closes: #913 Approved by: alexlarsson
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 7, 2017
These exist in the wild for flatpak, and aren't really a problem. The canonical permissions are still either `0755` or `0644`, we just support the additional writable bit for the group (i.e. extend the set to include `0775` and `0664`) now to avoid breaking some flatpak content. Closes: #913 Approved by: alexlarsson
|
💔 Test failed - status-atomicjenkins |
|
Pushed fixups ⬆️ |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 8, 2017
These exist in the wild for flatpak, and aren't really a problem. The canonical permissions are still either `0755` or `0644`, we just support the additional writable bit for the group (i.e. extend the set to include `0775` and `0664`) now to avoid breaking some flatpak content. Closes: #913 Approved by: alexlarsson
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These exist in the wild for flatpak, and aren't really a problem.
The canonical permissions are still
0{6,7}44, we just supportthe additional writable bit for the group now to avoid breaking
some flatpak content.