Make suffix optional in POST and remove from PATCH. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsoliangwu0130
requested changes
Aug 29, 2022
| @@ -1534,6 +1546,7 @@ components: | |||
| attributes: | |||
| allOf: | |||
| - $ref: '#/components/schemas/JobAttributes' | |||
| - $ref: '#/components/schemas/JobSuffixRequired' | |||
There was a problem hiding this comment.
I'm confused. Isn't suffix optional in POST?
| jobs that share the same position number. For updating existing | ||
| jobs, this field is required. | ||
| jobs that share the same position number. This field is required. | ||
| JobSuffixOptional: |
There was a problem hiding this comment.
Why do we have two suffix attributes defined and the only difference is nullable: true/false? I think what you should do are the following:
- Make suffix
nullable: truein post attributes. - Separate patch attributes from post attributes (you should still reuse common attributes by references).
- Remove suffix from patch attributes.
- Also make sure you modify the corresponding API codes including unit tests to reflect the change. For example, we will no longer need to check whether suffixes are matched between path and body for patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review. POST is not working.