re-add OtrDbContextFactory with appsettings import & exception handling #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myssto
requested changes
Sep 27, 2024
Database/OtrDbContextFactory.cs
Outdated
Comment on lines
26
to
34
| // If any errors are encountered (e.g. fetching the appsettings file fails), | ||
| // we want to return a default OtrContext. | ||
| // | ||
| // Without this specific implementation, the deployment will fail | ||
| // with a "Host can't be null" error. | ||
| // | ||
| // With this exception handling, the deployment will default to returning | ||
| // this value - this is enough for generating the migrations script | ||
| // used in deployments. |
myssto
reviewed
Sep 27, 2024
Co-authored-by: myssto <58118743+myssto@users.noreply.github.com>
myssto
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment fix, allows us to have a design-time dbcontextfactory which works both locally and in github actions :)