Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update home page content #15

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Update home page content #15

merged 6 commits into from
Jan 5, 2024

Conversation

danielq987
Copy link
Member

image
^^ side-by-side (left: old, right: new)

  • Added an image (its perpetualcolor for now)
  • Added how to join section
  • Made existing sections less verbose

I would appreciate feedback, especially from execs (regarding content).

@danielq987 danielq987 requested a review from yfxu January 3, 2024 07:00
Copy link
Member

@yfxu yfxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I like this about page much better than what I originally wrote XD

During the COVID-19 pandemic, club meetings were cancelled so as to protect the health of club members and other Waterloo students. In the event that another global health crisis emerges to once-more threaten societal stability, in-person meetings may be cancelled again.
## Club Meetings

osu!UWaterloo officially meets in-person bi-weekly, usually on Saturday 2-6pm at [PHYS 145](https://maps.app.goo.gl/eYAM98mDbcBJEHG8A). Please check the announcements channel in the Discord server to stay up-to-date!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can style "announcements" similar to how #verification was done:

"announcements" -> "#announcements"

Players who wish to compete at a competitive level are encouraged to play for the osu!UWaterloo collegiate teams.
These teams participate in [*osu! Collegiate League*](https://discord.gg/V5XhAcj) (o!CL) which runs every fall and winter term, with standard, mania, and taiko gamemodes. The osu!std league runs both a Tier 1 and Tier 2 tournament side-by-side, so players of all skill levels are encouraged to try out!

Please contact `pikapwn` on Discord if you are interested in competing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on changing pikapwn to @pikapwn?

@yfxu yfxu self-requested a review January 5, 2024 00:06
Copy link
Member

@yfxu yfxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea is there a copy of this image with larger dimensions? In the screenshot in the PR, the image doesn't span the entire width, and I feel like it'd look better if it did.

We could achieve that with either a CSS rule to set img { width: 100%; } with some more precise rules to only affect images in posts, or just get a larger image.

Copy link
Member Author

@danielq987 danielq987 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i purposely made the image smaller to fit inside the container LOL but yeah i added a css rule so that the image width is always 100% and got a larger image yay

@danielq987 danielq987 merged commit fe6a18d into master Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants