Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify load-rules.ts and utils/rules.ts to rules/index.ts #438

Closed
wants to merge 1 commit into from

Conversation

Foxeye-Rinx
Copy link
Contributor

  • The load-rules.ts and utils/rules.ts are working like an index, using an index file in src/rules/ allows us to remove them
  • The update-rules.ts is the generator of utils/rules.ts so it can be removed too

Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: 6dcd659

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Foxeye-Rinx Foxeye-Rinx marked this pull request as draft October 26, 2024 06:44
- The `load-rules.ts` and `utils/rules.ts` are working like an index, using an index file in `src/rules/` allows us to remove them
- The `update-rules.ts` is the generator of `utils/rules.ts` so it can be removed too
@Foxeye-Rinx Foxeye-Rinx marked this pull request as ready for review October 26, 2024 06:54
@Foxeye-Rinx Foxeye-Rinx changed the title Unify load-rules.ts and utils/rules.ts to rules/index.ts chore: unify load-rules.ts and utils/rules.ts to rules/index.ts Oct 26, 2024
@ota-meshi
Copy link
Owner

Hmm... Will src/rules/index.ts need to be maintained manually after this change?
If so, I don't want to maintain src/rules/index.ts manually, since rules are often added via pull requests from contributors.

@Foxeye-Rinx
Copy link
Contributor Author

Foxeye-Rinx commented Oct 26, 2024

I just created the #439 that might meet our expectations. I also added some minor improvements. Could you take a look and help me review the js import, I don't understand it so well.

@Foxeye-Rinx Foxeye-Rinx deleted the simplify branch October 27, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants