feat: add no-trailing-zeros rule
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0059bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
So weird, the test did not pass, it totally works on my side, I just changed some docs. 🤷 |
ota-meshi
requested changes
May 7, 2023
sxyazi
commented
May 7, 2023
ota-meshi
reviewed
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since YAML treats both
1.2and1.20as1.2, trailing zeros for numbers is not necessary, this rule enforces it.There are some bugs that arise from one getting the difference between
1.2and1.20wrong.Such as setting the Go version in GitHub Actions to have to use
"1.20"instead of1.20/1.2, which indicates the 20th version of Go, not of 2nd, this rule can discover and report it.See also (Chinese): https://twitter.com/haoel/status/1654074716968357888