Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withTokenizeWorker and Diff #193

Closed
ornic opened this issue Mar 1, 2023 · 5 comments
Closed

withTokenizeWorker and Diff #193

ornic opened this issue Mar 1, 2023 · 5 comments

Comments

@ornic
Copy link

ornic commented Mar 1, 2023

New typescript version breaks connection between withTokenizeWorker and Diff, both exported from react-diff-view.

image

Is this a planned break? If so, are there some simple update to old code? The one in https://github.com/otakustay/react-diff-view/blob/master/site/components/DiffView/index.tsx have rather different structure.

@otakustay
Copy link
Owner

Please provide me the errored code, I'll try to reproduce and fix it, it should be fully compatible

@Kondorok
Copy link

Kondorok commented Mar 9, 2023

https://codesandbox.io/s/gracious-spence-x2yec5?file=/src/App.tsx type error

@otakustay
Copy link
Owner

Please help verify if 3.0.3 fixes this issue

@ornic
Copy link
Author

ornic commented Mar 14, 2023

Thank you!

https://codesandbox.io/s/dry-sun-5clunm?file=/src/App.tsx

Сodesandbox is having problem loading newest version this fast

image

Hope they will update their caches soon.

@ornic
Copy link
Author

ornic commented Mar 14, 2023

But it work perfectly in our internal project! 👍

@ornic ornic closed this as completed Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants