Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37562: [Ruby] Add support for table.each_raw_record.to_a #3

Closed
wants to merge 2 commits into from

Conversation

otegami
Copy link
Owner

@otegami otegami commented Sep 6, 2023

Rationale for this change

This change aligns the behavior of each_raw_record with standard Ruby practices by returning an enumerator when no block is provided

What changes are included in this PR?

Are these changes tested?

Yes.

Are there any user-facing changes?

No

Closes: apache#37562

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@otegami otegami force-pushed the ruby-support-each-raw-record-no-block-given branch from 06b38b8 to 340cb64 Compare September 6, 2023 22:57
@otegami otegami changed the title Fix LocalJumpError in Arrow::Table#each_raw_record and Arrow::RecordB… GH-37562: [Ruby] Add support for table.each_raw_record.to_a Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

❌ GitHub issue apache#37562 could not be retrieved.

2 similar comments
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

❌ GitHub issue apache#37562 could not be retrieved.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

❌ GitHub issue apache#37562 could not be retrieved.

@otegami
Copy link
Owner Author

otegami commented Sep 6, 2023

I will create the PR on the original repo.

@otegami otegami closed this Sep 6, 2023
@otegami otegami deleted the ruby-support-each-raw-record-no-block-given branch September 6, 2023 23:17
@otegami otegami restored the ruby-support-each-raw-record-no-block-given branch September 6, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ruby] Add support for table.each_raw_record.to_a
1 participant