Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interleaving of asycnhronous callbacks #67

Closed

Conversation

parasyte
Copy link

@parasyte parasyte commented Jun 3, 2016

  • Create a new context when creating async callbacks; don't just push the current context to the stack.
  • This test would work if the callbacks were wrapped with ns.run() or ns.bind(), because this method creates a new context.
  • ns.bind() seems to have the same problem, but it has not been tested.
  • Added a new test for this specific failure.
  • Fixed an existing test which assumed contexts should not be created across async callbacks.
  • Fixes Continuations do not work across callbacks unless wrapped with namespace.run() #66

- Create a new context when creating async callbacks; don't just push the current context to the stack.
- This test would work if the callbacks were wrapped with ns.run() or ns.bind(), because this method creates a new context.
- ns.bind() seems to have the same problem, but it has not been tested.
- Added a new test for this specific failure.
- Fixed an existing test which assumed contexts should not be created across async callbacks.
@parasyte
Copy link
Author

Won't fix. See #66 (comment)

@parasyte parasyte closed this Jun 19, 2016
@parasyte parasyte deleted the bug/interleave-async-callbacks branch June 19, 2016 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant