Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #64

Closed
sineld opened this issue Jun 26, 2023 · 9 comments
Closed

Notifications #64

sineld opened this issue Jun 26, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sineld
Copy link

sineld commented Jun 26, 2023

Description

Wouldn't it be great if there was an optional feature to display a notification when the process begins and ends?

Desired Behavior

Notifications

Additional Context

No response

@sineld sineld added the enhancement New feature or request label Jun 26, 2023
@othyn othyn self-assigned this Jun 27, 2023
@othyn othyn added this to the Next Release milestone Jun 27, 2023
@othyn
Copy link
Owner

othyn commented Jun 27, 2023

Great suggestion! I'll take a look at this when I'm next looking at the project.

In the meantime, PR's are always welcome 😉

@AnonymousAlt0
Copy link
Contributor

AnonymousAlt0 commented Jun 29, 2023

I could have a look at this over the weekend.

@sineld
Copy link
Author

sineld commented Jun 29, 2023

I use enable and disable too much. I'd be a very handy feature for me. I hope your reliese it soon. Thanks.

@othyn
Copy link
Owner

othyn commented Jun 29, 2023

I could have a look at this over the weekend.

Happy to accept PR's on this! From playing around with the notification API on iOS in Swift, it seems fairly simple to setup a wrapper and trigger them on device. Hopefully that experience translates well to macOS.

@othyn
Copy link
Owner

othyn commented Jul 1, 2023

This will be in the next release, I'll fire one out now

@othyn othyn closed this as completed Jul 1, 2023
@sineld
Copy link
Author

sineld commented Jul 1, 2023

Thank you for the prompt update, everyone.

I have downloaded the latest version and granted the necessary permissions, but it is not working as expected. I even tried removing it completely, restarting macOS, and reinstalling it, but the issue persists.

2023-07-01 16-16-54 Auto Clicker

@AnonymousAlt0
Copy link
Contributor

I think I just experienced the same problem you're having. I was able to fix it by removing Auto Clicker from Accessibility settings outlined below, then opening the app and it worked as expected.

SCR-20230701-niyw

@sineld
Copy link
Author

sineld commented Jul 1, 2023

@AnonymousAlt0 I got it worked as you directed me, thanks.
Notifications pops up when started and when finished but no notifications is poping up on manual stop.

@othyn
Copy link
Owner

othyn commented Jul 1, 2023

@AnonymousAlt0 super, thank you for debugging that - it would have been my suggestion too. Not entirely sure why it was necessary as the app identifier hasn't changed... only fix could be to try and do a permissions reset on application load.

@sineld thats by intention at the moment, notifications are only fired at specified automated start/stop points.

@AnonymousAlt0 that does raise an important consideration though, if the user cancels the timer, are notifications cleared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants