fix: fixed 'Finished' notification appearing after manually cancelling timer #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fast fix! I'll get this merged, plan on doing another release shortly with some more bug fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'Finished' notification now no longer appears if the user cancels the timer early. Either within the app, in the menu bar, or with a shortcut.
Related Issue
Notifications #64
Motivation and Context
Fixes is bug so that if the user cancels the timer, notifications are cleared.
How Has This Been Tested?
Cancelled the timer in all possible ways, all of which function as expected. Both during the countdown phase, and while running. Also still works as before when not cancelling the timer.
Types of changes
Checklist