Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reflink FileCopyMethod (copy-on-write) #166

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

eth-p
Copy link
Contributor

@eth-p eth-p commented Aug 25, 2024

This commit is stacked on top of #165. That must be reviewed and merged first.

Note

I'm calling it reflink because that's what Linux users understand it as.

This brings copy-on-write file copying support as a FileCopyMethod.

Tests are passing: https://github.com/eth-p/forked-copy/actions/runs/10543146003/

TODO

  • Support on MacOS
  • Support on Linux
  • CI Testing MacOS
  • CI Testing Linux

@eth-p eth-p force-pushed the feat-copymethod-reflink branch 2 times, most recently from f225cea to a812a19 Compare August 25, 2024 01:41
@eth-p eth-p force-pushed the feat-copymethod-reflink branch 5 times, most recently from 2a79585 to af89a8b Compare September 14, 2024 20:58
@eth-p eth-p marked this pull request as ready for review September 14, 2024 20:58
@eth-p eth-p changed the title [DRAFT] feat: Add reflink FileCopyMethod (copy-on-write) feat: Add reflink FileCopyMethod (copy-on-write) Sep 14, 2024
@eth-p eth-p force-pushed the feat-copymethod-reflink branch from af89a8b to 16a2a50 Compare September 14, 2024 21:04
@eth-p eth-p force-pushed the feat-copymethod-reflink branch from 16a2a50 to b87e8c9 Compare September 27, 2024 02:46
When we add support for reflinks, we need to make sure we are able
to check that regressions aren't introduced. Explicitly testing
on different filesystems allows us to do that.
We want comprehensive testing, no matter the FileCopyMethod.
Using an environment variable is a quick, clean, and easy way to do
this.
The only `FileCopyMethod` that supports this is CopyBytes.
The only `FileCopyMethod` that supports this is CopyBytes.
@eth-p eth-p force-pushed the feat-copymethod-reflink branch from b87e8c9 to 06711a6 Compare September 27, 2024 06:07
@otiai10 otiai10 self-requested a review October 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant