Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Skip now accepts FileInfo #92

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

otiai10
Copy link
Owner

@otiai10 otiai10 commented Oct 26, 2022

Close #40

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #92 (fa129b1) into main (705b76e) will increase coverage by 0.36%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   77.96%   78.33%   +0.36%     
==========================================
  Files           9        9              
  Lines         177      180       +3     
==========================================
+ Hits          138      141       +3     
  Misses         19       19              
  Partials       20       20              
Impacted Files Coverage Δ
options.go 83.33% <ø> (-2.39%) ⬇️
copy.go 78.76% <90.47%> (+1.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@otiai10 otiai10 force-pushed the breaking-change/skip-with-fileinfo branch from 46aa855 to 8749e2c Compare November 9, 2022 02:28
@otiai10 otiai10 merged commit 4c7c24d into main Nov 9, 2022
@otiai10 otiai10 deleted the breaking-change/skip-with-fileinfo branch November 10, 2022 00:34
@MrAlias
Copy link

MrAlias commented Oct 22, 2023

Why wasn't this released as a v2? Breaking the stable v1 API is causing a diamond dependency problem during upgrades of packages that depend on this.

@otiai10
Copy link
Owner Author

otiai10 commented Oct 23, 2023

That was the decision I made at that time.
Please use / encourage to use the latest version.
I'll make major version update for further breaking change.

If you think it's worth making revert commit on v1 and make v2 with breaking change separately, let's discuss.

@MrAlias
Copy link

MrAlias commented Oct 23, 2023

I'll make major version update for further breaking change.

I think you are correct, and this is probably the best that can be done at this point.

If you think it's worth making revert commit on v1 and make v2 with breaking change separately, let's discuss.

Making a change like this would in itself cause more breakages.

Thank you for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants