Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lua VoiceModule to NPCs #2932

Merged
merged 5 commits into from
Apr 18, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 11, 2020

the XML tag sucks and we all know it does, this module is great, by ORTS

also added an example on the runes npc

Evil Puncker added 2 commits April 10, 2020 22:05
the XML tag sucks and we all know, this module is great, by ORTS

also added an example on the runes npc
@DSpeichert DSpeichert requested a review from a team April 14, 2020 02:15
Copy link
Contributor

@TheSumm TheSumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a minor note

data/npc/lib/npcsystem/modules.lua Outdated Show resolved Hide resolved
TheSumm
TheSumm previously approved these changes Apr 15, 2020
@DSpeichert DSpeichert merged commit ec0fd32 into otland:master Apr 18, 2020
@ghost ghost deleted the voice-module branch April 19, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants