Print duplicate storages #3072
Merged
Print duplicate storages #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that this will not be added to the repository, but it can be useful for customs servers. Function taken from: https://github.com/opentibiabr/otservbr-global/pull/1158/commits Credits to the created: @andersonfaaria Co-Authored-By: Anderson Faria <andercfaria@hotmail.com>
|
this is kinda interesting, but the benchmark part is unnecessary (this code takes almost no resources to run), and this should include the GlobalStorageKeys table as well |
ghost
added
the
dudantas
previously approved these changes
Jun 1, 2020
There is no global storage to check, this can easily be introduced later. |
DSpeichert
reviewed
Jun 3, 2020
Co-authored-by: Daniel Speichert <DSpeichert@users.noreply.github.com>
DSpeichert
approved these changes
Jun 9, 2020
ghost
approved these changes
Jun 9, 2020
ghost
merged commit
Znote
added a commit
to Znote/forgottenserver
that referenced
this pull request
Jun 15, 2020
This reverts commit d26ee0b.
Znote
added a commit
that referenced
this pull request
Jun 15, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this will not be added to the repository, but it can be useful for customs servers.
Function taken from: https://github.com/opentibiabr/otservbr-global/pull/1158/commits