Server save script improvements

[omarcopires]

Now the map will not be cleared before restarting the server.

[DSpeichert]

I don't see the previous version opening the server back. Did it make sense? Was there a reason for it?

[omarcopires]

Não vejo a versão anterior abrindo o servidor de volta. Fez sentido? Havia alguma razão para isso?

There is no reason to be able to clean if you will shutdown to restart it.

[Zbizu]

how is this script supposed to save server when it doesn't have saveServer() anywhere? (also applies to the one we currently have in tfs)

also while we're at it, why there is no /save talkaction?

[MillhioreBT]

I don't see the previous version opening the server back. Did it make sense? Was there a reason for it?

I agree with @DSpeichert
the only situations in which the server is actually saved is when it is closed or when it is shut down, why is this event called ServerSave? if your main purpose is not really to save the server every so often, the name LastServerSave makes more sense :D

I always thought this was a mistake, I had to create my own custom event for this purpose, since the current script is useless, it is not useful at all

However, what you propose fixes what did not work before 🤩 👏

[DSpeichert]

It still doesn't actually call saveServer as @Zbizu pointed out.
I understand that by closing the server, it kicks people out, which in turns saves all those players that were kicked out - but not those that are immune to server closing via special permissions.

Do we want to keep that behavior with closing the server or use the saveServer function instead?
I'd think that if you kick all the players (by closing server) you might as well restart it.

[Zbizu]

kicking players is ok - they get saved before everything else so no rollback will happen in case of crash on save scenario

however, saveServer has to be called in order to save houses

Clean can be executed last, after everything was saved.