-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added isKey itemtype #3679
added isKey itemtype #3679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source edit is redundant as you can simply define function ItemType:isKey() return self:getType() == ITEM_TYPE_KEY end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the C++ change in favor of Lua as zbizu pointed out
Pull Request Prelude
Changes Proposed
Issues addressed:
now you can add numbers to a key using /i silver key, 1234 for example.