Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of defining currencies #3699

Merged
8 commits merged into from
Dec 1, 2021
Merged

Possibility of defining currencies #3699

8 commits merged into from
Dec 1, 2021

Conversation

MillhioreBT
Copy link
Contributor

@MillhioreBT MillhioreBT commented Sep 28, 2021

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

  • Define new currencies or configure existing ones
  • The npc bank has been ignored because it treats currencies very specifically and we still do not have a convention of what currencies should be called
  • The method Game.getCurrenyItems returns a table with the ItemType of each currency, this table is ordered from lowest to highest , so the first currency will always be the most cheapest and the expensive will be the last
  • Added a methods for ItemType and Item, this method is getWorth

Issues addressed: Nothing!

@ghost ghost requested review from ranisalt, a user, DSpeichert, nekiro and yamaken93 September 28, 2021 00:39
@MillhioreBT MillhioreBT requested a review from a user September 28, 2021 08:52
@ghost ghost added the feature New feature or functionality label Sep 28, 2021
data/lib/core/player.lua Outdated Show resolved Hide resolved
src/items.cpp Outdated Show resolved Hide resolved
MillhioreBT and others added 2 commits September 29, 2021 12:37
Co-authored-by: soul4soul <5142635+soul4soul@users.noreply.github.com>
Co-authored-by: soul4soul <5142635+soul4soul@users.noreply.github.com>
@ghost ghost merged commit 40206c5 into otland:master Dec 1, 2021
Silba93 added a commit to Silba93/BlackTek-Bygone that referenced this pull request Sep 24, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants