-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move player task-delay #3717
Move player task-delay #3717
Conversation
I think it would be nicer if we had them at game.h as we have these: https://github.com/otland/forgottenserver/blob/master/src/game.h#L66-L69 |
Its a good point. Changed. |
that would still mean they are hardcoded, so no point in pr xD |
At least we avoid the magic numbers sprinkled around |
Big finger on phone screen attacks again |
Looks good, making code more readable. However, I would use the same convention as other variables do, that is: first the prefix, then the rest of variable name. Like INTERVAL_* Like this: MOVE_CREATURE_INTERVAL ->INTERVAL_MOVE_CREATURE Other than that, LGTM! |
I didn't find use of interval on front, but I like |
Ignore that, I was going too much into details 😉 |
did it close #1845? |
No, delay here is from the server and has nothing to do with packets. |
Pull Request Prelude
Changes Proposed