Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use min skill level on Vocation::getReqSkillTries #3730

Merged
1 commit merged into from
Nov 1, 2021
Merged

Use min skill level on Vocation::getReqSkillTries #3730

1 commit merged into from
Nov 1, 2021

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Use min skill level on Vocation::getReqSkillTries

#3721

@ghost ghost requested review from DSpeichert, nekiro and ranisalt October 14, 2021 03:19
@ramon-bernardo
Copy link
Contributor Author

We have a problem here.

  • Change MINIMUM_SKILL_LEVEL to 1.
  • Create player with skill level 9 or below 10.
  • Kill the player.
  • An incorrect value is saved in db, because of std::pow(skillMultipliers[skill], static_cast<int32_t>(9 - 11)).
  • skillMultipliers[skill] ^ -2

This must be merged for MINIMUM_SKILL_LEVEL to work correctly.

@ghost ghost merged commit 38ade02 into otland:master Nov 1, 2021
@ghost ghost deleted the min-skllvl-voc branch November 1, 2021 17:10
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Jan 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant